Fix: Pass autocompleteBraces setting to source editor#2169
Open
William-Laverty wants to merge 1 commit intoCodeEditApp:mainfrom
Open
Fix: Pass autocompleteBraces setting to source editor#2169William-Laverty wants to merge 1 commit intoCodeEditApp:mainfrom
William-Laverty wants to merge 1 commit intoCodeEditApp:mainfrom
Conversation
Reads the autocompleteBraces setting via @appsettings and passes it to the SourceEditorConfiguration's behavior, enabling the setting to actually control whether brackets are auto-completed in the editor. Requires corresponding change in CodeEditSourceEditor. Fixes CodeEditApp#1691
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reads the
autocompleteBracessetting via@AppSettingsand passes it to theSourceEditorConfiguration.Behavior, enabling the existing toggle to actually control bracket auto-completion.Changes
@AppSettings(\.textEditing.autocompleteBraces)toCodeFileViewSourceEditorConfiguration.behaviorDependencies
Fixes