Improve display of SSVC decision tree in UI using YAML format #2058#2165
Open
Mahaboobunnisa123 wants to merge 2 commits intoaboutcode-org:mainfrom
Open
Improve display of SSVC decision tree in UI using YAML format #2058#2165Mahaboobunnisa123 wants to merge 2 commits intoaboutcode-org:mainfrom
Mahaboobunnisa123 wants to merge 2 commits intoaboutcode-org:mainfrom
Conversation
7f9427a to
fdf9ef7
Compare
…de-org#2058 Signed-off-by: Mahaboobunnisa123 <mdshabbi885@gmail.com>
fdf9ef7 to
e4c0a6b
Compare
Author
|
hi @pombredanne , Please review the PR #2165 and would happy to make any adjustments based on the feedback. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #2058
This PR improves the readability of SSVC decision trees in the advisory detail UI by rendering them as clean, human-readable YAML instead of Python's default
pprintrepr output.What changed
vulnerabilities/templatetags/ssvc_filters.pyto_yamlusingsaneyamlvulnerabilities/templates/advisory_detail.html{{ ssvc.options|pprint }}with{{ ssvc.options|to_yaml }}vulnerabilities/tests/test_ssvc_filters.pyWhy
saneyaml?I chose
saneyamloverPyYAMLbecause it's already a project dependency (setup.cfgline 80) and the project historically prefers it (ref: #452).Before
After
Tests
All 3 tests pass locally:
No new dependencies were added. Happy to make any adjustments based on review feedback!