fix: skip token revocation when no token was acquired#918
Open
Dave-London wants to merge 1 commit intoanthropics:mainfrom
Open
fix: skip token revocation when no token was acquired#918Dave-London wants to merge 1 commit intoanthropics:mainfrom
Dave-London wants to merge 1 commit intoanthropics:mainfrom
Conversation
Add a check for non-empty github_token output before attempting to revoke the app token in the cleanup step. When the prepare phase fails (e.g., unsupported event type with track_progress), no token is acquired, causing the cleanup curl to send an empty Bearer token and produce a confusing "Bad credentials" 401 error. Fixes anthropics#858 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
steps.run.outputs.github_token != ''condition to the "Revoke app token" cleanup stepProblem
The "Revoke app token" step runs with
if: always(), meaning it executes even when the prepare phase fails (e.g.,track_progressused with an unsupported event type). When no token was acquired, the curl sends an emptyAuthorization: Bearerheader, producing a 401 "Bad credentials" error that confuses users debugging the actual failure.Changes
action.yml: Addedsteps.run.outputs.github_token != ''to the existingifcondition on the "Revoke app token" stepTest plan
Fixes #858