GH-130: Fix AutoCloseables to work with @Nullable structures#1017
Merged
jbonofre merged 1 commit intoapache:mainfrom Feb 17, 2026
Merged
Conversation
axreldable
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Please add the |
axreldable
force-pushed
the
ARROW-130-checker-framework-autocloseables-annotations
branch
from
338980c to
d5c317c
Compare
jbonofre
approved these changes
Feb 17, 2026
Member
jbonofre
left a comment
jbonofre
left a comment
There was a problem hiding this comment.
I don't have problem to add @Nullable. That said, I don't consider as a bug fix but more as improvement.
| */ | ||
| public static AutoCloseable all(final Collection<? extends AutoCloseable> autoCloseables) { | ||
| public static AutoCloseable all( | ||
| final @Nullable Collection<? extends @Nullable AutoCloseable> autoCloseables) { |
Member
There was a problem hiding this comment.
I don't have problem to add @Nullable here.
| public static void close(Throwable t, AutoCloseable... autoCloseables) { | ||
| public static void close(Throwable t, @Nullable AutoCloseable... autoCloseables) { | ||
| if (autoCloseables == null) { | ||
| return; |
Member
There was a problem hiding this comment.
That should not happen, but it seems you have a case ;)
Contributor
Author
There was a problem hiding this comment.
Yes, they are saying it's not overly cautious.
https://stackoverflow.com/a/28271272/8269828
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
AutoCloseablessupposes to work with nullableIterables,varargs, andcollection of nulls. The PR introduces:@Nullableannotation for all public methods inAutoCloseables(only privateflattenmethod doesn't support nullIterable)nullchecks to prevent NPEsThe change is backward compatible. Only possible NPEs are prevented.
Closes #130 .