Conversation
rcosta358
commented
Feb 14, 2026
Comment on lines
+184
to
+185
| if (fi == null) | ||
| return; |
rcosta358
commented
Feb 14, 2026
Comment on lines
-414
to
-417
| } else { | ||
| assert false; | ||
| // Method should already be in context. Should not arrive this point in | ||
| // refinement checker. |
Collaborator
Author
There was a problem hiding this comment.
We cannot assume this anymore because a method that throws InvalidRefinementError on a parametric refinement will not be added to the context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where when a class had multiple methods and one method would throw an error related to a parametric refinement (e.g.,
InvalidRefinementError), the exception would abort the visitation of sibling methods during the first pass. Then, in second pass, when trying to get the function that should have been added to the context in the first pass, it is not there, and would throw aNullPointerException. This was because there were missing try-catch blocks in thegetMethodRefinementsandgetConstructorRefinements(in this case, the first one).Example Reproduction