Use pkg-config instead of mapnik-config.#274
Open
sebastic wants to merge 1 commit intomapnik:masterfrom
Open
Conversation
cjmayo
reviewed
Feb 16, 2026
| '-lmapnik-wkt', | ||
| '-lmapnik-json', | ||
| ]) | ||
| lib_path = os.path.join(check_output(['pkg-config', '--variable=prefix', 'libmapnik']),'lib') |
Contributor
There was a problem hiding this comment.
libdir can provide the full path, and work when lib64 is used
lib_path = check_output(['pkg-config', '--variable=libdir', 'libmapnik'])
Contributor
Author
There was a problem hiding this comment.
Please feel free to push your changes if your a maintainer, or create a PR with your changes.
I gave up on python-mapnik and had it removed from Debian.
cjmayo
reviewed
Feb 16, 2026
| return output.rstrip('\n') | ||
|
|
||
| linkflags = [] | ||
| lib_path = os.path.join(check_output([mapnik_config, '--prefix']),'lib') |
Contributor
There was a problem hiding this comment.
With 4.2.1 need bin_path now too.
bin_path = os.path.join(check_output(['pkg-config', '--variable=prefix', 'libmapnik']),'bin')
Contributor
Author
There was a problem hiding this comment.
With python-mapnik removed from Debian I have no more need for these changes, please push your changes if you're a maintainer or create your own PR to supersede this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CMake buildsystem for Mapnik 4.x doesn't build mapnik-config, pkg-config should be used instead.