Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
ISessionMigrationHandlerto enable session migration across horizontally-scaled server instances (#1155), and rejects non-initialize POST requests without a session ID in stateful mode (#1000).Description
When MCP servers are deployed behind a load balancer, a client's session may land on a server instance that doesn't recognize the session ID. This PR introduces an opt-in
ISessionMigrationHandlerinterface (registered via DI) that allows servers to persist session init data and restore sessions on demand.Session migration flow:
initializehandshake,OnSessionInitializedAsyncis called so the server can persist theInitializeRequestParams(e.g., to Redis or a database).AllowSessionMigrationAsyncis called. If it returns the originalInitializeRequestParams, a new local session is created with that client state pre-populated; no re-initialization required from the client's perspective.Reject sessionless non-initialize requests in stateful mode
In stateful mode, POST requests without a session ID are now rejected with 400 unless the message is an
initializerequest. This required reorderingHandlePostRequestAsyncto read the JSON-RPC message before deciding on session creation. Stateless mode is unaffected.Notable design decisions:
ISessionMigrationHandlerlives inModelContextProtocol.Core(not AspNetCore).StreamableHttpServerTransport(similar toEventStreamStore), andHandleInitRequestAsyncis public so migration can call it directly without going through a full POST flow.KnownClientCapabilitieswas added toMcpServerOptions, following the existingKnownClientInfopattern.Fixes #1155
Fixes #1000