Skip to content

Fix flaky sse-retry conformance test caused by CI timing sensitivity#1279

Open
Copilot wants to merge 4 commits intomainfrom
copilot/fix-flaky-tests-ci
Open

Fix flaky sse-retry conformance test caused by CI timing sensitivity#1279
Copilot wants to merge 4 commits intomainfrom
copilot/fix-flaky-tests-ci

Conversation

Copy link
Contributor

Copilot AI commented Feb 15, 2026

The sse-retry client conformance test fails intermittently in CI because the conformance runner (v0.1.13) exits with code 1 for warnings, and network overhead on CI runners causes the SSE reconnection to arrive ~259ms late (759ms vs 500ms retry interval). The runner itself marks this as a WARNING ("acceptable but may indicate network delays"), not a FAILURE.

  • Parse conformance runner output to distinguish warning-only results from actual failures
  • Treat 0 failed, N warnings (N > 0) as passing, since warnings represent acceptable behavior per the conformance spec
var success = process.ExitCode == 0 || HasOnlyWarnings(output, error);

Real failures (client doesn't reconnect, wrong behavior) still fail the test. Only timing-sensitive warnings caused by unavoidable network latency are tolerated.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits February 15, 2026 15:19
The conformance test runner exits with code 1 when there are warnings,
even if all checks pass. Timing-sensitive checks like SSE retry can
produce warnings in CI due to network/processing overhead, causing
flaky test failures.

Parse the conformance output to detect warning-only results (0 failures,
>0 warnings) and treat them as passing.

Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
Copilot AI changed the title [WIP] Investigate and fix flaky tests in CI Fix flaky sse-retry conformance test caused by CI timing sensitivity Feb 15, 2026
Copilot AI requested a review from stephentoub February 15, 2026 15:25
@stephentoub stephentoub marked this pull request as ready for review February 15, 2026 15:33
@stephentoub stephentoub enabled auto-merge (squash) February 15, 2026 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants