Skip to content

Fix add_vline and add_hline with datetime axes #5508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mosh3eb wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

Fix add_vline and add_hline with datetime axes #5508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion plotly/shapeannotation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,14 @@
def _mean(x):
if len(x) == 0:
raise ValueError("x must have positive length")
return float(sum(x)) / len(x)
# Handle non-numeric values (e.g., date strings)
# For vline/hline, x0==x1 and y0==y1, so returning first value is correct
try:
return float(sum(x)) / len(x)
except TypeError:
# If sum fails (e.g., for date strings), return the first value
# This works because for vlines x0==x1, and for hlines y0==y1
return x[0]


def _argmin(x):
Expand Down