Pyo3/some sketch reloading#64
Merged
tychedelia merged 11 commits intoprocessing:mainfrom Feb 16, 2026
Merged
Conversation
catilac
commented
Feb 2, 2026
| config.set( | ||
| // TODO: this needs to be handed to us by python | ||
| ConfigKey::SketchRootPath, | ||
| "/home/moon/Code/libprocessing/crates/processing_pyo3/examples".to_string(), |
catilac
force-pushed
the
pyo3/some_sketch_reloading
branch
from
84c9975 to
c93fd20
Compare
Contributor
Author
|
@tychedelia this is as far as i got with the sketch reloading stuff. |
fix AssetEvent handler for Sketch entities
Clean up debug statements Remove unused code
catilac
force-pushed
the
pyo3/some_sketch_reloading
branch
from
ff5e44b to
0883b57
Compare
tychedelia
approved these changes
Feb 16, 2026
| } | ||
|
|
||
| fn extensions(&self) -> &[&str] { | ||
| &["py"] |
Member
There was a problem hiding this comment.
This should probably be configurable.
| let mut graphics = get_graphics_mut(module)?; | ||
|
|
||
| // TODO: this shouldn't be on the graphics object | ||
| let sketch = graphics.poll_for_sketch_update()?; |
Member
There was a problem hiding this comment.
Yeah, I think we need some kind of top level Sketch entry point in python itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially and poorly addresses #61
Current issues:
run()everytime we reloadglobalvariables with us. but this will likely be solved by an alternative sketch structure (like a class, or something like quill where we are explicit)