subtests: fix inconcistent handling of non-string messages#14196
Open
radoering wants to merge 2 commits intopytest-dev:mainfrom
Open
subtests: fix inconcistent handling of non-string messages#14196radoering wants to merge 2 commits intopytest-dev:mainfrom
radoering wants to merge 2 commits intopytest-dev:mainfrom
Conversation
psf-chronographer
bot
added
the
bot:chronographer:provided
nicoddemus
requested changes
Feb 15, 2026
Member
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
Thanks, but both tests pass on main, so they are not really testing the issue.
Author
How is this possible? I tested locally that the second test fails before creating the PR. I reverted the fix for now and you can see that the second test fails in CI. My branch should be up to date with The first test passes without the change. I only created it as regression test for the symmetry between the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #14195