-
-
Notifications
You must be signed in to change notification settings - Fork 34.1k
gh-143535: Dispatch on the second argument if generic method is instance-bindable #144615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
johnslavik
wants to merge
21
commits into
python:main
Choose a base branch
from
johnslavik:fix-bound-arg-handling-singledispatchmethod
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+78
−2
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
5479e0f
Dispatch on the second argument if generic method is instance-bindable
johnslavik 3455cd9
Only cut off first argument if method becomes bound
johnslavik 1142577
Cutoff on function, not method!
johnslavik d05750f
Cut first argument after the fact!
johnslavik b81977b
Fix missing import
johnslavik f6afaec
Fix formatting
johnslavik 9dac097
Intentionally don't handle an edge case
johnslavik 354721b
Add tests
johnslavik d80e5d1
Fix formatting
johnslavik 97f23cd
Add news entry
johnslavik 12cd97a
Rewrite comments
johnslavik 1a24e43
Inline argument cutoff condition
johnslavik 615c284
Empty commit to unstuck GitHub processing recent push
johnslavik ab7d78c
Add correct GitHub references
johnslavik dd804d2
Make the implementation more debuggable
johnslavik 85c318d
Fix `staticmethod` bug
johnslavik 21dcd02
Assign the boolean directly
johnslavik 4c1cfd7
Simplify method dispatch
johnslavik e3538f5
More meaningful variable names
johnslavik 0878b55
Reiterate on the code
johnslavik 373deb0
Write a "What's New" entry
johnslavik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
Misc/NEWS.d/next/Library/2026-02-09-02-16-36.gh-issue-144615.s04x4n.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| Methods directly decorated with :deco:`functools.singledispatchmethod` now | ||
| dispatch on the second argument when called after being accessed as class | ||
| attributes. Patch by Bartosz Sławecki. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.