fix warnings in jit builds#144817
Merged
Fidget-Spinner merged 3 commits intopython:mainfrom Feb 14, 2026
Merged
Conversation
chris-eibl
requested review from
Fidget-Spinner,
brandtbucher,
diegorusso,
markshannon,
savannahostrowski and
tomasr8
as code owners
chris-eibl
added
skip issue
skip news
build
chris-eibl
commented
Feb 14, 2026
| return -1; | ||
| } | ||
| int old; | ||
| DWORD old; |
Member
Author
There was a problem hiding this comment.
incompatible pointer types passing 'int *' to parameter of type 'PDWORD' (aka 'unsigned long *') [-Wincompatible-pointer-types]
chris-eibl
commented
Feb 14, 2026
Python/optimizer.c
Outdated
| tracer->initial_state.executor = (_PyExecutorObject *)Py_XNewRef(current_executor); | ||
| tracer->initial_state.exit = exit; | ||
| tracer->initial_state.stack_depth = stack_pointer - _PyFrame_Stackbase(frame); | ||
| tracer->initial_state.stack_depth = (int)((uintptr_t)stack_pointer - (uintptr_t)_PyFrame_Stackbase(frame)); |
Member
Author
There was a problem hiding this comment.
warning C4244: '=': conversion from '__int64' to 'int', possible loss of data
chris-eibl
commented
Feb 14, 2026
Python/optimizer.c
Outdated
| depth = _PyUop_Caching[uop].entries[depth].output; | ||
| } | ||
| return write - output; | ||
| return (int)((uintptr_t)write - (uintptr_t)output); |
Member
Author
There was a problem hiding this comment.
warning C4244: 'return': conversion from '__int64' to 'int', possible loss of data
chris-eibl
commented
Feb 14, 2026
| #endif | ||
| for (int i = 4; i < 8; i++) { | ||
| if ((true_bits ^ false_bits) & (1 << i)) { | ||
| if ((true_bits ^ false_bits) & (uintptr_t)(1 << i)) { |
Member
Author
There was a problem hiding this comment.
Here and below
warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits
chris-eibl
commented
Feb 14, 2026
| } | ||
|
|
||
| op(_BINARY_OP_EXTEND, (left, right -- res, l, r)) { | ||
| op(_BINARY_OP_EXTEND, (descr/4, left, right -- res, l, r)) { |
Member
Author
There was a problem hiding this comment.
descr/4 was missing here. The code generator "takes" it from bytecodes.c, hence the
PyObject *descr = (PyObject *)this_instr->operand0;
line was already in optimizer_cases.h without it.
The (void)descr; below then silences the unused warning.
chris-eibl
commented
Feb 14, 2026
| break; | ||
| } | ||
| int returning_stacklevel = this_instr->operand1; | ||
| int returning_stacklevel = (int)this_instr->operand1; |
Member
Author
There was a problem hiding this comment.
Here and below
warning C4244: 'initializing': conversion from 'uint64_t' to 'int', possible loss of data
chris-eibl
commented
Feb 14, 2026
| long index = PyLong_AsLong(sym_get_const(ctx, sub_st)); | ||
| assert(index >= 0); | ||
| int tuple_length = sym_tuple_length(tuple_st); | ||
| Py_ssize_t tuple_length = sym_tuple_length(tuple_st); |
Member
Author
There was a problem hiding this comment.
warning C4244: 'initializing': conversion from 'Py_ssize_t' to 'int', possible loss of data
Fidget-Spinner
approved these changes
Feb 14, 2026
Member
|
Uh oh the tests are failing. |
Member
Author
Fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are warnings in jit builds in CI and build bots.