Skip to content

[3.11] gh-144833: Fix use-after-free in SSL module when SSL_new() fails (GH-144843) #144861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
miss-islington wants to merge 1 commit into
base: 3.11
Choose a base branch
from
+4 −1
Open

[3.11] gh-144833: Fix use-after-free in SSL module when SSL_new() fails (GH-144843) #144861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Library/2026-02-15-00-00-00.gh-issue-144833.TUelo1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fixed a use-after-free in :mod:`ssl` when ``SSL_new()`` returns NULL in
``newPySSLSocket()``. The error was reported via a dangling pointer after the
object had already been freed.
2 changes: 1 addition & 1 deletion Modules/_ssl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,8 +844,8 @@ newPySSLSocket(PySSLContext *sslctx, PySocketSockObject *sock,
self->ssl = SSL_new(ctx);
PySSL_END_ALLOW_THREADS
if (self->ssl == NULL) {
_setSSLError(get_state_ctx(sslctx), NULL, 0, __FILE__, __LINE__);
Copy link
Contributor

@caje731 caje731 Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my curiosity - any benefits to moving decref further down? The only thing I can think of is if get_state_ctx begins holding (indirect / chain) references to self again through its argument, moving the decref down is appropriately defensive.

Py_DECREF(self);
_setSSLError(get_state_ctx(self), NULL, 0, __FILE__, __LINE__);
return NULL;
}
/* bpo43522 and OpenSSL < 1.1.1l: copy hostflags manually */
Expand Down
Loading