PEP 803: Position abi3t as a new variant; use Py_TARGET_ABI3T to select it#4747
PEP 803: Position abi3t as a new variant; use Py_TARGET_ABI3T to select it#4747encukou merged 6 commits intopython:mainfrom
Conversation
Co-authored-by: Ralf Gommers <ralf.gommers@gmail.com>
|
Thank you! |
|
From more discussion, a new knob called |
ngoldbaum
left a comment
There was a problem hiding this comment.
I left a few more comments after my main one.
For what it's worth, I have a branch of PyO3 that compiles with _Py_OPAQUE_PYOBJECT set on the GIL-enabled build. If I also define Py_GIL_DISABLED, then I hit issues in PyO3 internals because PyCriticalSection isn't exposed. I could stub out the critical section wrappers like they're currently stubbed on the GIL-enabled build, but then the resulting extensions won't be safe on the free-threaded build.
The tests run, but I get a segfault early on that I'm still debugging - it may be a CPython bug but it may also be a bug in how I set up _Py_OPAQUE_PYOBJECT support in PyO3. I'm meeting with David Hewitt tomorrow morning to figure that out.
|
I plan to merge this early next week and update the discussion. |
PEP 123: Summary of changes)📚 Documentation preview 📚: https://pep-previews--4747.org.readthedocs.build/