Open
Conversation
https://github.com/eclecticiq/python-data-uri is a small library implementing parsing of the data: uri scheme defined in RFC2397. Library still supported python 3.3, and lacks any inline type comments. Library is stable and works fine in python 3.14.
This comment has been minimized.
This comment has been minimized.
Collaborator
brianschubert
left a comment
brianschubert
left a comment
There was a problem hiding this comment.
Looks good! One minor suggestion:
stubs/datauri/datauri/datauri.pyi
Outdated
Comment on lines
3
to
4
|
|
||
| RE_DATA_URI: Pattern[str] # undocumented |
Collaborator
There was a problem hiding this comment.
Constants should be marked as Final:
Suggested change
| RE_DATA_URI: Pattern[str] # undocumented | |
| from typing import Final | |
| RE_DATA_URI: Final[Pattern[str]] # undocumented |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Author
|
Thanks for the suggestion; added Final in fe44fd6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/eclecticiq/python-data-uri is a small library implementing parsing of the data: uri scheme defined in RFC2397.
Library still supported python 3.3, and lacks any inline type comments. Library is stable and works fine in python 3.14.