feat(credentials): multiple credentials per provider#3211
Open
icecrasher321 wants to merge 29 commits intostagingfrom
Open
feat(credentials): multiple credentials per provider#3211icecrasher321 wants to merge 29 commits intostagingfrom
icecrasher321 wants to merge 29 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
|
Too many files changed for review. ( |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Collaborator
Author
|
bugbot run |
...omponents/editor/components/sub-block/components/credential-selector/credential-selector.tsx
Show resolved
Hide resolved
Collaborator
Author
|
bugbot run |
Collaborator
Author
|
bugbot run |
Collaborator
Author
|
bugbot run |
apps/sim/app/api/v1/admin/workspaces/[id]/members/[memberId]/route.ts
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
bugbot run |
| await db | ||
| .delete(account) | ||
| .where(and(eq(account.userId, session.user.id), eq(account.id, accountId))) | ||
| } else if (providerId) { |
There was a problem hiding this comment.
Account disconnect ignores provider filter
Low Severity
When accountId is provided, deletion matches only account.userId and account.id, and ignores the requested provider. A mismatched request can disconnect a different provider account than the one the caller selected, because the provider input is no longer enforced in this branch.
Collaborator
Author
There was a problem hiding this comment.
not a real problem
Collaborator
Author
|
bugbot run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Credentials to add multiple connections to same integration
Type of Change
Testing
Added unit tests, tested multiple cases manually. Tested backfill.
Checklist