Draft
Conversation
- Modified isEdgeProtected to only check target block protection - Outbound connections (from locked blocks) can now be added/removed - Inbound connections (to locked blocks) remain protected - Updated notification messages and comments to reflect the change Co-authored-by: Emir Karabeg <emir-karabeg@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR modifies the block protection logic to allow adding and removing outbound connections from locked blocks. Previously, all connections involving a locked block (both inbound and outbound) were protected. Now, only inbound connections to a locked block are protected, ensuring that a locked block's internal state cannot be altered by external connections, while still allowing its outputs to be freely managed.
Fixes # (issue) - Assuming this is an improvement, not a specific bug fix, but linking to an issue if one exists would be good.
Type of Change
Testing
The
isEdgeProtectedfunction was updated to only consider the target block for protection. This allows operations on outbound connections from locked blocks while maintaining protection for inbound connections.Reviewers should verify:
tscandlintchecks passed.Checklist
Screenshots/Videos
Slack Thread