Skip to content

fix(deployments): external build token generation issue#3070

Merged
myftija merged 5 commits intomainfrom
skip-external-build-fix
Feb 16, 2026
Merged

fix(deployments): external build token generation issue#3070
myftija merged 5 commits intomainfrom
skip-external-build-fix

Conversation

@myftija
Copy link
Collaborator

@myftija myftija commented Feb 16, 2026

Fixes an issue introduced in #3024.

The behavior for local builds in older CLI versions relies on externalBuildData to be defined to distinguish from the self-hosting local build path, even though it doesn't actually use the token.

@changeset-bot
Copy link

changeset-bot bot commented Feb 16, 2026

🦋 Changeset detected

Latest commit: b44bfb8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages
Name Type
@trigger.dev/sdk Patch
trigger.dev Patch
@trigger.dev/core Patch
@trigger.dev/python Patch
@internal/sdk-compat-tests Patch
d3-chat Patch
references-d3-openai-agents Patch
references-nextjs-realtime Patch
references-realtime-hooks-test Patch
references-realtime-streams Patch
references-telemetry Patch
@trigger.dev/build Patch
@trigger.dev/redis-worker Patch
@trigger.dev/schema-to-json Patch
@internal/cache Patch
@internal/clickhouse Patch
@internal/redis Patch
@internal/replication Patch
@internal/run-engine Patch
@internal/schedule-engine Patch
@internal/testcontainers Patch
@internal/tracing Patch
@internal/tsql Patch
@internal/zod-worker Patch
@trigger.dev/react-hooks Patch
@trigger.dev/rsc Patch
@trigger.dev/database Patch
@trigger.dev/otlp-importer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 16, 2026

Caution

Review failed

The pull request is closed.

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 653920c and b44bfb8.

📒 Files selected for processing (1)
  • packages/cli-v3/src/commands/deploy.ts

Walkthrough

Adds explicit local-build handling end-to-end. The CLI gains a new --local-build option (conflicts with --nativeBuildServer) and related option refinements; deploy command propagates isLocalBuild through initialization. API schema (InitializeDeploymentRequestBody) now includes optional isLocalBuild?: boolean. initializeDeployment server logic uses a generateExternalBuildToken flag and either produces a placeholder ExternalBuildData or calls createRemoteImageBuild. deployment.server conditionally spreads externalBuildData into BUILDING updates only when present. A patch-level changeset was added.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete. It lacks required sections: Testing, Changelog, and Screenshots, and does not follow the template structure. Complete the PR description using the template: add Testing section describing test steps, Changelog section with change details, and Screenshots section if applicable.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The PR title clearly summarizes the main change: fixing an issue with external build token generation in deployment workflows.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch skip-external-build-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

@myftija myftija force-pushed the skip-external-build-fix branch from 967455f to 9f19f50 Compare February 16, 2026 16:56
devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

@myftija myftija merged commit 7af789b into main Feb 16, 2026
32 of 33 checks passed
@myftija myftija deleted the skip-external-build-fix branch February 16, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants