Append _wixcert_ to CA test for rollback check#606
Draft
bevanweiss wants to merge 1 commit intowixtoolset:mainfrom
Draft
Append _wixcert_ to CA test for rollback check#606bevanweiss wants to merge 1 commit intowixtoolset:mainfrom
bevanweiss wants to merge 1 commit intowixtoolset:mainfrom
Conversation
Contributor
Author
|
I think maybe the whole |
Member
|
It's been a long time since I looked at the cert custom actions, but IIRC the thumbprint could be provided as a property so it wasn't necessarily a stable identifier that could be used to uninstall the certificate later. This is fuzzy, but it may be that the cert install behavior needs more of a re-design to address the suffix... which is why that issue was just hanging out unfixed. |
…ength calculation from the pwzUniquePrefix string, and using this in the compare. Fixes #3976 Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>
bevanweiss
force-pushed
the
iis_append_wixcert
branch
from
b3a1152 to
bab13ff
Compare
robmen
force-pushed
the
main
branch
5 times, most recently
from
adeb395 to
cd5f73d
Compare
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taken from wixtoolset/wix3/pull/546, but have left out the explicit length calculation from the pwzUniquePrefix string, and using this in the compare.
Fixes wixtoolset/issues#3976